yamt commented on code in PR #16756:
URL: https://github.com/apache/nuttx/pull/16756#discussion_r2230061679
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -1090,9 +1090,12 @@ choice ESP32S3_SPIRAM_HEAP
config ESP32S3_SPIRAM_COMMON_HEAP
bool "Additional region to kernel heap"
+ depends on !ESP32S3_SPIFLASH && !ESPRESSIF_WIFI && !BUILD_PROTECTED
Review Comment:
> I'd stick with kernel/user heap separation in this case and remove
CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP for ESP32-S3 in the future.
i didn't know you wanted to deprecate CONFIG_XTENSA_IMEM_USE_SEPARATE_HEAP.
i always think nuttx should have something like esp-idf's heap caps.
for small devices, separate heaps are often too wasteful wrt space.
> Please note that for ESP32-S3 there are no limitations on accessing
PSRAM's through the instruction bus (something that is true for ESP32).
i know. my configuration uses it for text heap. (text segment of wamr aot
modules)
> Please check
https://github.com/apache/nuttx/pull/16756#issuecomment-3113617106
i will reply there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
