ThePassionate commented on code in PR #13173:
URL: https://github.com/apache/nuttx/pull/13173#discussion_r2230445567
##########
crypto/cryptosoft.c:
##########
@@ -388,38 +391,41 @@ int swcr_authenc(FAR struct cryptop *crp)
/* Supply MAC with AAD */
- aadlen = crda->crd_len;
- /* Section 5 of RFC 4106 specifies that AAD construction consists of
- * {SPI, ESN, SN} whereas the real packet contains only {SPI, SN}.
- * Unfortunately it doesn't follow a good example set in the Section
- * 3.3.2.1 of RFC 4303 where upper part of the ESN, located in the
- * external (to the packet) memory buffer, is processed by the hash
- * function in the end thus allowing to retain simple programming
- * interfaces and avoid kludges like the one below.
- */
-
- if (crda->crd_flags & CRD_F_ESN)
+ if (aad)
Review Comment:
@yamt please review https://github.com/apache/nuttx/pull/16771 if it helps
solve your problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
