xiaoxiang781216 commented on PR #16742: URL: https://github.com/apache/nuttx/pull/16742#issuecomment-3117244942
> > ``` > > 2. Many host APIs lack robust error recovery when interrupted by signals. For example, when read() a file is interruped by a signal, it will return error directly. (here disable interrupt maybe better) > > ``` > > if we are using host calls in a way which can't tolerate signals, it's a bug. how it should be fixed really depends. eg. handle EINTR, SA_RESTART, mask signals, make a loop, etc it isn't a good idea to blindly mask signals. Retry loop for EINTR doesn't work very well for many 3rd party library since 3rd party code doesn't consider or test with the environment that signal happen randomly and frequently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
