acassis commented on code in PR #16772:
URL: https://github.com/apache/nuttx/pull/16772#discussion_r2232893935
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -302,6 +302,10 @@ config IMX9_FLEXSPI
bool "ENABLE FLEXSPI interface"
default n
+config IMX9_PCI_EP
+ bool "ENABLE PCI EP"
Review Comment:
Please rename to: "Enable PCI EP"
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -302,6 +302,10 @@ config IMX9_FLEXSPI
bool "ENABLE FLEXSPI interface"
Review Comment:
Rename to "Enable FLEXSPI Interface"
Rational: NuttX used Capitalized by default:
$ git grep "ENABLE " | grep bool
arch/arm64/src/imx9/Kconfig: bool "ENABLE FLEXSPI interface"
$ git grep "Enable " | grep bool | wc
1077 7208 72654
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -302,6 +302,10 @@ config IMX9_FLEXSPI
bool "ENABLE FLEXSPI interface"
default n
+config IMX9_PCI_EP
+ bool "ENABLE PCI EP"
+ default n
+
Review Comment:
Please include a ---help---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
