xiaoxiang781216 commented on code in PR #16743:
URL: https://github.com/apache/nuttx/pull/16743#discussion_r2234513067
##########
arch/arm64/include/imx9/chip.h:
##########
@@ -44,12 +44,16 @@
#define MB(x) (KB(x) << 10)
#define GB(x) (MB(UINT64_C(x)) << 10)
-#if defined(CONFIG_ARCH_CHIP_IMX93)
+#if defined(CONFIG_ARCH_CHIP_IMX93) || defined(CONFIG_ARCH_CHIP_IMX95)
Review Comment:
should we remove this #if/#endif directly
##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -23,6 +23,13 @@ config ARCH_CHIP_IMX93
EL3/OCRAM is a bad combination for atomic instructions, they
don't work.
Instead, use A53 that will have no atomic instruction set
available.
+config ARCH_CHIP_IMX95
Review Comment:
move to first patch
##########
arch/arm64/src/imx9/Make.defs:
##########
@@ -28,13 +28,16 @@ endif
# i.MX9-specific C source files
-CHIP_CSRCS = imx9_boot.c imx9_ccm.c imx9_clockconfig.c imx9_gpio.c
-CHIP_CSRCS += imx9_iomuxc.c imx9_timer.c
+CHIP_CSRCS = imx9_boot.c imx9_timer.c
Review Comment:
move to first patch too
##########
boards/Kconfig:
##########
@@ -2402,6 +2402,14 @@ config ARCH_BOARD_IMX93_EVK
This options selects support for NuttX on the NXP i.MX93 CPUs
EVK
board with ARM Cortex-A55.
+config ARCH_BOARD_IMX95_A55_EVK
Review Comment:
why need add A55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
