ThePassionate commented on issue #3142: URL: https://github.com/apache/nuttx-apps/issues/3142#issuecomment-3125936882
@yamt https://github.com/apache/nuttx-apps/pull/3144 fix this issue and aligned error value with mbedtls test suits firstly, with introduce of shax_update in header file like [https://github.com/Mbed-TLS/mbedtls/blob/v3.6.4/include/mbedtls/sha1.h#L130](url) There is no strict rule that the return value of this function will be an error. This is because the buindin implementation will not be wrong, so error value will not be obtained. However, in the official test set, there is indeed an illegal parameter check for the judgment parameters of the 'shax_starts' function. so i add the input value check and show in following `nsh> test_suite_shax` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/1 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/2 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/3 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/4 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/5 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/6 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/7 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/8 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/9 .................................... PASS` `SHA-1 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/10 ................................... PASS` `SHA-256 Invalid parameters ........................................ PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/1 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/2 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/3 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/4 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/5 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/6 .................................. PASS` `SHA-224 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/7 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/1 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/2 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/3 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/4 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/5 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/6 .................................. PASS` `SHA-256 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/7 .................................. PASS` `SHA-512 Invalid parameters ........................................ PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/1 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/2 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/3 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/4 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/5 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/6 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/7 .................................. PASS` `SHA-384 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/8 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/1 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/2 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/3 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/4 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/5 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/6 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/7 .................................. PASS` `SHA-512 Test Vector NIST CAVS https://github.com/apache/nuttx-apps/pull/8 .................................. PASS` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
