eren-terzioglu commented on code in PR #16866:
URL: https://github.com/apache/nuttx/pull/16866#discussion_r2287258808
##########
boards/xtensa/esp32s3/common/src/Make.defs:
##########
@@ -36,6 +36,9 @@ endif
ifeq ($(CONFIG_SPI_DRIVER),y)
CSRCS += esp32s3_board_spidev.c
+ ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
+ CSRCS += esp32s3_board_spislavedev.c
+ endif
endif
Review Comment:
```suggestion
ifeq ($(CONFIG_SPI_DRIVER),y)
CSRCS += esp32s3_board_spidev.c
ifeq ($(CONFIG_SPI_SLAVE_DRIVER),y)
CSRCS += esp32s3_board_spislavedev.c
endif
endif
```
Other devices implemented it seperately. For consistency reasons could you
change it?
[Here is an
implementation](https://github.com/apache/nuttx/blob/master/boards/risc-v/esp32c6/common/src/Make.defs#L41-L47)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]