michallenc commented on issue #16916: URL: https://github.com/apache/nuttx/issues/16916#issuecomment-3227345609
Looking at the ioctls, I'm not sure why `arch/risc-v/src/bl808/bl808_gpadc.c` implements `ANIOC_RESET_FIFO` and `ANIOC_SAMPLES_ON_READ` at all. These were intended to be common ioctl calls and are implemented in an upper layer `drivers/analog/adc.c` to allow manipulation with a receive FIFO queue, not to directly access the peripheral's hardware queues. The call won't even get there, so I would say they can be removed from gpadc driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
