acassis commented on code in PR #16976:
URL: https://github.com/apache/nuttx/pull/16976#discussion_r2323412562
##########
tools/mkexport.sh:
##########
@@ -185,10 +187,15 @@ cp "${TOPDIR}/tools/incdir.c" "${EXPORTDIR}/tools/."
# Copy the board specific linker if found, or use the default when not.
APPLD=gnu-elf.ld
+APPLDIN=gnu-elf.ld.in
+
if [ -f "${BOARDDIR}/scripts/${APPLD}" ]; then
cp -f "${BOARDDIR}/scripts/${APPLD}" "${EXPORTDIR}/scripts/."
-else
+elif [ -f "${TOPDIR}/libs/libc/elf/${APPLD}" ]; then
cp -f "${TOPDIR}/libs/libc/elf/${APPLD}" "${EXPORTDIR}/scripts/."
+elif [ -f "${TOPDIR}/libs/libc/elf/${APPLDIN}" ]; then
+ # Fall back to exporting the template if the real file is missing
+ cp -f "${TOPDIR}/libs/libc/elf/${APPLDIN}" "${EXPORTDIR}/scripts/${APPLD}"
Review Comment:
I think this part shouldn't be included, because if the file doesn't exist
is because LIBC_MODLIB is not enabled, then this file cannot be used by
applications anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
