linguini1 commented on code in PR #16978:
URL: https://github.com/apache/nuttx/pull/16978#discussion_r2326285631


##########
Documentation/contributing/making-changes.rst:
##########
@@ -265,6 +265,21 @@ squash before submitting the Pull Request:
    happy, they may suggest squashing and merging again to make a single 
commit. In this case you would repeat steps
    1 through 6.
 
+   .. note::
+
+      NuttX uses a ``CODEOWNERS`` file to help track which users are "experts"
+      on certain NuttX subsystems. Sometimes, this will result in certain
+      reviewers being automatically requested to review your PR if you have
+      modified a file they are marked as a "code owner" for. This is just to
+      help contributors get more relevant reviews from someone who knows the
+      subject area.
+
+      If you've created a new file, let's say for a driver, you can add 
yourself

Review Comment:
   I would agree to do both. Personally I think that re-generating the file 
should be used sparingly, like if it got quite out of sync. Only because it's 
not the most readable. 
   
   What is more readable is something like a single author board port being 
listed as `/boards/arm64/bcm2711/* @linguini1`. I hope to make this improvement 
to the generation script, so my idea was just to have people update CODEOWNERS 
by hand if they remember. If they don't, oh well. We can always re-generate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to