sumpfralle opened a new pull request, #16997:
URL: https://github.com/apache/nuttx/pull/16997

   ## Summary
   
   The functions `hw_write_masked` and `hw_xor_bits` (as defined in pico-sdk) 
were defined twice in NuttX.
   Additionally these definitions were in conflict (one lacked the `volatile` 
modifier).
   
   Now these functions and their dependencies are defined in a new header file.
   Its name is based on the filename of the original definition in pico-sdk:
   
   ```
     src/rp2_common/hardware_base/include/hardware/address_mapped.h
   ```
   
   ## Impact
   
   This change should fix the potential issue of GPIO operations failing due to 
compiler optimizations caused by the absence of `volatile`.
   
   ## Testing
   
   The changes were compile-tested. Previously compilation failed. Since my 
project does not use these specific functions on the rp2040 board, I cannot 
prove their correctness.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to