raiden00pl commented on code in PR #3170: URL: https://github.com/apache/nuttx-apps/pull/3170#discussion_r2347225968
########## netutils/libshvc/Kconfig: ########## @@ -0,0 +1,11 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +config NETUTILS_LIBSHVC + bool "Silicon Heaven Protocol (lightweight C implementation)" + select NETUTILS_LIBULUT Review Comment: `select XXX` has its problems and should be avoided when possible. There were discussions about this topic in several places on github lately (I don't remember exactly where) and on the mailing list: https://lists.apache.org/thread/n7qq5341cln5d3d4roy5nj23yc8hgzn6 The conclusion is that we should use `select` only for options that are not visible to the user. BTW, the user can always show hidden symbols using "show-all mode" in menuconfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
