linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2347519109
########## include/nuttx/arch.h: ########## @@ -99,6 +99,18 @@ #define DEBUGPOINT_BREAKPOINT 0x04 #define DEBUGPOINT_STEPPOINT 0x05 +/* Ensure that LOOPSPERMSEC is not the default, invalid value. If it is, let + * the user know that they need to change it and then calibrate it. + */ + +static_assert( + CONFIG_BOARD_LOOPSPERMSEC >= 0, Review Comment: > there are many method to implement the busy wait loop, it's better to put your assert to the place which really use this macro. But this is used in many different places, so it would require replicating the assert statement many times -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
