ppisa commented on code in PR #3181: URL: https://github.com/apache/nuttx-apps/pull/3181#discussion_r2349783185
########## netutils/plcatool/CMakeLists.txt: ########## @@ -0,0 +1,33 @@ +# ############################################################################## +# apps/netutils/plcatool/CMakeLists.txt Review Comment: I am not sure because there is some remains of `ethtool` mentioning in the NuttX code and may it be, separate tool for specific purpose is better for start when it is complete for its basic task. The use it as template for other more generic tool or even combining functionality into one application could be good evolution. But I think that providing application which would take the name `ethtool` and people would find it and then be disappointed that it does not have basic equivalent functionality of Linux `ethtool` is not ideal. May it be @michallenc or @Cynerd could provide their input there as well. They are in need of PLCA functionality now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
