xiaoxiang781216 commented on PR #17056: URL: https://github.com/apache/nuttx/pull/17056#issuecomment-3319131571
> HI @suoyuanG > > 1. I don't think it is a good idea to use `up_check_tcbstack `to do this stack overflow check, `up_check_tcbstack` was designed for checking how many stack has been used. > it's naturally extension to limit the check range. Anyway, we can rename up_check_tcbstack to up_check_tcbstack_range, and map up_check_tcbstack to up_check_tcbstack_range(tcb, tcb->adjust_stack_size). > 2. Also it is not a good idea to add checking in arch level.. > I can't understand, both approach change the arch code. > 3. you should also consider the cases that CONFIG_SCHED_SUSPENDSCHEDULER is not enabled, and the context switch in nxtaxk_exit > > > Please check this [PR17043](https://github.com/apache/nuttx/pull/17043), I looks like we are going to add a same function with different solution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
