tinnedkarma commented on code in PR #17190: URL: https://github.com/apache/nuttx/pull/17190#discussion_r2425382151
########## arch/arm/src/common/arm_internal.h: ########## @@ -479,6 +479,13 @@ size_t arm_stack_check(void *stackbase, size_t nbytes); void arm_stack_color(void *stackbase, size_t nbytes); #endif +#if defined(CONFIG_STACK_COLORATION) &&\ + defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3 +void arm_color_intstack(void); Review Comment: Uhh, but it's not always a symbol, sometime it's a define which after the preprocessing step is resolved to nothing (if the #ifdefs are not correctly defined). Somehow, my reasoning is opposite. I think there is more info guarding the function call (usually I see the function call first, then I search for the implementation), rather than guarding the function implementation. Nevertheless, I just left a comment to improve my understanding of codebase, It should not be blocking for merge. ########## arch/arm/src/common/arm_internal.h: ########## @@ -479,6 +479,13 @@ size_t arm_stack_check(void *stackbase, size_t nbytes); void arm_stack_color(void *stackbase, size_t nbytes); #endif +#if defined(CONFIG_STACK_COLORATION) &&\ + defined(CONFIG_ARCH_INTERRUPTSTACK) && CONFIG_ARCH_INTERRUPTSTACK > 3 +void arm_color_intstack(void); Review Comment: Uhh, but it's not always a symbol, sometime it's a define which after the preprocessing step is resolved to nothing (if the #ifdefs are not correctly defined). Somehow, my reasoning is opposite. I think there is more info guarding the function call (usually I see the function call first, then I search for the implementation), rather than guarding the function implementation. Nevertheless, I just left a comment to improve my understanding of the codebase, It should not be blocking for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
