linguini1 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2452448635
########## boards/sim/sim/sim/configs/vncserver/defconfig: ########## @@ -12,6 +12,7 @@ CONFIG_ARCH_BOARD_SIM=y CONFIG_ARCH_CHIP="sim" CONFIG_ARCH_SIM=y CONFIG_BOARD_LATE_INITIALIZE=y +CONFIG_BOARD_LOOPSPERMSEC=0 Review Comment: I've reverted #14450 in #17221. This makes the sim architecture respect delays properly now. Please review it if you have the time. My plan once that is merged is to rebase this PR to include those changes. I think in this PR I will add a DEBUGASSERT to the `arch_timer.c` implementation to avoid the case where `g_oneshot_lower == NULL && CONFIG_BOARD_LOOPSPERMSEC == 0`, since that is another scenario where delays will be ignored. Then I feel comfortable keeping all sim configurations with `CONFIG_BOARD_LOOPSPERMSEC=0` and we can move on to getting sane values for the rest of the NuttX configurations missing a non-default value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
