xiaoxiang781216 commented on PR #17339: URL: https://github.com/apache/nuttx/pull/17339#issuecomment-3541969697
> > > @Fix-Point I think this API oneshot changing is a break change because some users maintained drivers will stop to work. Please indicate it in the PR > > > > > > Tick interface is optional, and only a few oneshot driver provide the implementation. @Fix-Point will provide more fast, accuacy and clean implementation of all these drivers in the next pr. > > Thank you @xiaoxiang781216 ! It should be nice if he can test Audio Tone generator and fix it, someone from xiaomi sent a patch about 3 years ago that broke it. I only discovered it because @JorgeGzm tried to use it and it was not working. I did bitsect and found which PR broke it, but I don't remember exactly what PR, it was some one related to had parent and thread child are created which patch break the audio tone? this driver doesn't have any siginicant change from 2020. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
