ajuckler commented on PR #17344: URL: https://github.com/apache/nuttx/pull/17344#issuecomment-3551012821
> Please update the impact section, it isn't none if you've changed the driver. > > Also, I don't think these changes should be merged until they are tested with an I2C based EEPROM (since you mentioned you only compile tested that). I have a board with one, I can try to test this patch against it in the next few days (unless someone else beats me to it). Updated, I meant "none" in the sense that as long as the ioctl isn't called the behaviour doesn't differ from the current one. I don't have a I2C EEPROM at hand so any help in testing this bit is definitely welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
