acassis commented on PR #3214: URL: https://github.com/apache/nuttx-apps/pull/3214#issuecomment-3557567314
> > @Otpvondoiats you don't need to close the PR to fix the issues in the review, just create a new PR with modifications and use "git rebase -i HEAD~2" to squash it and "git push -f" to force a push to replace the older commit in the repo. > > This process is explained here: https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request > > The reason I closed this PR is that I plan to merge these two submissions into one. Donny9 suggested I keep these, but my own repository branch for the for loop has been deleted, so there will be two PR. Thank you for explanation. It is a good practice to add the reason the PR was closed, it avoid confusion like in the case of nxinit closed PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
