xiaoxiang781216 commented on code in PR #3216: URL: https://github.com/apache/nuttx-apps/pull/3216#discussion_r2545833465
########## nshlib/nsh.h: ########## @@ -1176,16 +1176,16 @@ int cmd_switchboot(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); int cmd_unset(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); #endif -#ifndef CONFIG_NSH_DISABLE_KILL +#if !defined(CONFIG_NSH_DISABLE_KILL) && !defined(CONFIG_DISABLE_SIGNALS) int cmd_kill(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); #endif #if defined(CONFIG_FS_PROCFS) && !defined(CONFIG_NSH_DISABLE_PKILL) int cmd_pkill(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); #endif -#ifndef CONFIG_NSH_DISABLE_SLEEP +#if !defined(CONFIG_NSH_DISABLE_SLEEP) && !defined(CONFIG_DISABLE_SIGNALS) int cmd_sleep(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); #endif -#ifndef CONFIG_NSH_DISABLE_USLEEP +#if !defined(CONFIG_NSH_DISABLE_USLEEP) && !defined(CONFIG_DISABLE_SIGNALS) int cmd_usleep(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv); Review Comment: sleep is an important function, we need support the partial disable signal functionality to make CONFIG_DISABLE_SIGNALS is useful in the real case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
