extinguish commented on PR #17357: URL: https://github.com/apache/nuttx/pull/17357#issuecomment-3562691157
> > > The detailed implementation is different, both approach could benefit in the different usage. It's better to introduce the disable level concept, so both pr could be merged. > > > > > > Why do we need two PRs for this? I already have a PR that disables signals. If the level-control approach works, it would be straightforward to integrate it into #17352. Opening a new PR would only consume additional reviewer time. I think we should focus on improving the existing PR instead. > > It's fine to use one pr to do the work, but someone need help to merge them. For example, for example, this pr contain more clean than #17352: https://github.com/apache/nuttx/pull/17357/files#diff-9e6b14f89a1f89e46914da0086d8e74e4d511ce0907333ca592dfda73368207fR132-R138 > > Bascially, we can arrange the pr into three part: > > 1. Skip the signal dispatch in each arch. Both pr do the same thing, but we need merge the change to ensure the skip completeness. > 2. One patch skip the signal dispatch in the common code > 3. Final patch skip all signal related function > > Who volunteers to complete this work? @wangchdo or @extinguish. Well, the initial split is now complete: 1. The arch-related parts have been merged into a unified patch 2. The signal handling portion is now a separate patch(may need further review to make modification) 3. The signal-related function dependencies, currently mainly needed by projects under apps, have been placed in another pull request: https://github.com/apache/nuttx-apps/pull/3217 The "One patch skip the signal dispatch in the common code" part may need clarification regarding the disable level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
