Cynerd commented on code in PR #17360: URL: https://github.com/apache/nuttx/pull/17360#discussion_r2550054041
########## include/sys/param.h: ########## @@ -53,6 +53,32 @@ # define nitems(_a) (sizeof(_a) / sizeof(0[(_a)])) #endif /* nitems */ +/* Macros for counting and rounding. */ + +#ifndef howmany +# define howmany(a, b) (((a) + ((b) - 1)) / (b)) +#endif /* howmany */ Review Comment: Yes. It is added to provide a complete set of macros what BSD provides (https://man.freebsd.org/cgi/man.cgi?query=roundup&sektion=9&manpath=NetBSD+8.0). Adding only some of them doesn't feel right to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
