acassis commented on code in PR #17371:
URL: https://github.com/apache/nuttx/pull/17371#discussion_r2557232438
##########
net/icmpv6/icmpv6_input.c:
##########
@@ -332,7 +333,7 @@ void icmpv6_input(FAR struct net_driver_s *dev, unsigned
int iplen)
case ICMPv6_NEIGHBOR_ADVERTISE:
{
FAR struct icmpv6_neighbor_advertise_s *adv;
-
+ bool should_process = false;
Review Comment:
Suggestion: use a more explicit name, it helps people that will read this
code in the future. I suggest using "is_for_this_node" instead of
"should_process". Although in the "else" it tests for allnodes the packet needs
to be handle locally. Other option could be "is_local_or_allnodes_dest"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
