jasonbu commented on PR #3219: URL: https://github.com/apache/nuttx-apps/pull/3219#issuecomment-3585609687
> @jasonbu You can't assume that if something works in Xiaomi internal repo, it will also work with the upstream. Xiaomi repositories are not synchronized with the upstream. This has led to bugs before. Changes to Apache repositories should be tested with Apache repositories. Splitting PRs into smaller ones is safer because it's easier to do reviews, even if the cost is higher CI usage. Sure, we have to re check to ensure no any break when upstream, as these change a all small and in apps, merged commits into one pr here. Next pr will make it more clear and more relative and more convenient for reviewer。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
