linguini1 commented on code in PR #17377:
URL: https://github.com/apache/nuttx/pull/17377#discussion_r2569315374
##########
arch/arm/src/imx6/imx_serial.c:
##########
@@ -599,7 +599,7 @@ static int imx_attach(struct uart_dev_s *dev)
{
/* Configure as a (high) level interrupt */
- arm_gic_irq_trigger(priv->irq, false);
+ up_set_irq_type(priv->irq, IRQ_HIG_HLEVEL);
Review Comment:
This indicates that the changes were not even compile-tested. I will not
trust this PR getting merged unless good test logs are provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
