linguini1 commented on PR #17375: URL: https://github.com/apache/nuttx/pull/17375#issuecomment-3587691866
> done Please read the contributing guidelines. The description is still insufficient. First off, the description still contains the following template text: > PRs without testing information will not be accepted. We will request test logs. This portion, ironically, asks for test logs. Letting us know what command you used to invoke QEMU is good step, but that is still not a test log. It is not sufficient "testing" to invoke QEMU and see that NuttX boots. You've made a functional change to the PCI driver. How are you testing that change specifically, in the driver? Are you invoking the driver? It's also not clear from your description (at least to me) what the fix is. You mention: > X86_64:init bar in bios, In NuttX, PCI should not be enumerated again; it is only necessary to calculate the size of the BARs. > kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION failed This doesn't really make sense to me. What is this error and under what conditions was it occurring before? How does your change fix that? Was NuttX failing to boot before this change? It is not well described. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
