michallenc commented on code in PR #17416:
URL: https://github.com/apache/nuttx/pull/17416#discussion_r2580642476
##########
arch/arm/src/stm32h5/stm32_serial.c:
##########
@@ -2242,8 +2434,15 @@ static void stm32serial_shutdown(struct uart_dev_s *dev)
* then this may need to be a configuration option.
Review Comment:
Please remove the revisit section as it is no longer valid.
Btw, is there a use case where you want to unconfigure TX and not, let's
say, RX? If not, we could simplify the configuration to just
`LPUARTX_UNCONFIG_PINS_ON_CLOSE`. But I am not sure about use cases here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
