This is an automated email from the ASF dual-hosted git repository.

linguini pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 452557a249a633b094427f1d92ebf6982118ac77
Author: ligd <[email protected]>
AuthorDate: Wed Jan 22 13:08:36 2025 +0800

    binfmt: Fix error handling in exec_module
    
    Remove an extra return statement in exec_module failure path,
    ensuring proper cleanup when errors occurs.
    
    Signed-off-by: ligd <[email protected]>
---
 binfmt/binfmt_execmodule.c | 1 -
 sched/environ/environ.h    | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/binfmt/binfmt_execmodule.c b/binfmt/binfmt_execmodule.c
index d1c35d9b626..979c9b5ce15 100644
--- a/binfmt/binfmt_execmodule.c
+++ b/binfmt/binfmt_execmodule.c
@@ -369,7 +369,6 @@ errout_with_tcbinit:
 #endif
 
   nxtask_uninit(tcb);
-  return ret;
 
 errout_with_addrenv:
 #if defined(CONFIG_ARCH_ADDRENV) && defined(CONFIG_BUILD_KERNEL)
diff --git a/sched/environ/environ.h b/sched/environ/environ.h
index 5035c812c9c..939b0f32d36 100644
--- a/sched/environ/environ.h
+++ b/sched/environ/environ.h
@@ -36,7 +36,7 @@
 
 #ifdef CONFIG_DISABLE_ENVIRON
 #  define env_dup(group, envp) (0)
-#  define env_release(group)   (0)
+#  define env_release(group)   ((void)0)
 #else
 
 #  define SCHED_ENVIRON_RESERVED (4)

Reply via email to