xiaoxiang781216 commented on PR #17489:
URL: https://github.com/apache/nuttx/pull/17489#issuecomment-3652604068

   > > Please include some test cases that verify the functionality of the new 
feature. It is good that ostest passes with the timer enabled, since I saw you 
mentioned that the hrtimer will be used for the system tick. However, I think 
we need tests that verify the actual precision on the hrtimer and also show 
that the systicks are the correct duration, etc.
   > 
   > @linguini1 @jerpelea I have added the test code and test logs. Please 
check them in the PR description.
   > 
   > Formal test cases will be added to the apps repository after this PR is 
merged.
   > 
   > As shown in the test code, `hrtimer_init`, `hrtimer_start`, and 
`hrtimer_cancel `are all covered. The test logs also demonstrate that the 
behavior matches the expected results.
   
   it's better to add the test to ostest, so we can monitor the regression 
regularly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to