anchao commented on code in PR #17499:
URL: https://github.com/apache/nuttx/pull/17499#discussion_r2617803215
##########
drivers/serial/serial.c:
##########
@@ -273,7 +271,7 @@ static int uart_putxmitchar(FAR uart_dev_t *dev, int ch,
bool oktoblock)
* See https://github.com/apache/nuttx/issues/14662
*/
- flags = enter_critical_section();
+ flags = uart_spinlock(dev, true);
Review Comment:
`critical_section` is fast than `rspinlock` in AMP mode, We should consider
1 core scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
