wangchdo commented on code in PR #17489: URL: https://github.com/apache/nuttx/pull/17489#discussion_r2621522508
########## sched/hrtimer/hrtimer_cancel.c: ########## @@ -0,0 +1,102 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer_cancel.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <errno.h> +#include <hrtimer/hrtimer.h> + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: hrtimer_cancel + * + * Description: + * Cancel a high-resolution timer. The timer is removed from the active + * timer RB-tree. If the canceled timer was the earliest in the tree, the + * queue expiration is adjusted to: + * + * 1. The next earliest timer in the tree, or + * 2. A safe default expiration (current time + HRTIMER_DEFAULT_INCREMENT) + * if the tree is empty. + * + * Input Parameters: + * hrtimer - Pointer to the high-resolution timer instance to be canceled. + * + * Returned Value: + * OK (0) on success, or a negated errno value on failure. + * + * Assumptions/Notes: + * - This function locks the timer tree with spinlock + * to ensure safe access. + * - The expiration of the next timer (or default) is + * set via hrtimer_starttimer(). + ****************************************************************************/ + +int hrtimer_cancel(FAR hrtimer_t *hrtimer) +{ + FAR hrtimer_t *first_hrtimer; + irqstate_t flags; + uint64_t now; + uint64_t expired; + int ret = OK; + + /* Enter critical section to protect the RB-tree */ + + flags = enter_critical_section(); Review Comment: Done ########## sched/hrtimer/hrtimer_process.c: ########## @@ -0,0 +1,121 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer_process.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <assert.h> Review Comment: Done ########## sched/hrtimer/hrtimer_start.c: ########## @@ -0,0 +1,135 @@ +/**************************************************************************** + * sched/hrtimer/hrtimer_start.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/arch.h> +#include <nuttx/clock.h> +#include <errno.h> +#include <hrtimer/hrtimer.h> Review Comment: Done ########## include/nuttx/hrtimer.h: ########## @@ -0,0 +1,159 @@ +/**************************************************************************** + * include/nuttx/hrtimer.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_HRTIMER_H +#define __INCLUDE_NUTTX_HRTIMER_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/clock.h> +#include <nuttx/compiler.h> +#include <nuttx/spinlock.h> + +#include <stdint.h> +#include <sys/tree.h> + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* High-resolution timer modes: + * + * HRTIMER_MODE_ABS - Absolute expiration time + * HRTIMER_MODE_REL - Relative timeout from current time + */ + +enum hrtimer_mode_e +{ + HRTIMER_MODE_ABS = 0x0, /* Absolute expiration time */ + HRTIMER_MODE_REL = 0x1 /* Relative delay from now */ +}; + +/* Forward declarations */ + +struct hrtimer_s; +struct hrtimer_node_s; +typedef struct hrtimer_s hrtimer_t; +typedef struct hrtimer_node_s hrtimer_node_t; + +/* Callback type for high-resolution timer expiration */ + +typedef void (*hrtentry_t)(FAR struct hrtimer_s *); + +/* Red-black tree node for hrtimer */ + +struct hrtimer_node_s +{ + RB_ENTRY(hrtimer_node_s) entry; /* RB-tree linkage for sorted insertion */ +}; + +/* High-resolution timer instance */ + +struct hrtimer_s +{ + struct hrtimer_node_s node; /* RB-tree node for sorted insertion */ + hrtentry_t func; /* Expiration callback function */ Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
