anchao commented on PR #17517: URL: https://github.com/apache/nuttx/pull/17517#issuecomment-3669875819
> > Dear NuttX PMC and Committers, > > > > 1. I believe the current PR meets the merging criteria. The submitter has provided documentation, test suites and performance data. In addition, this submission serves as an optional feature for the timer subsystem and does not block any existing devices. > > 2. PMC member @xiaoxiang781216 has conducted multiple rounds of code reviews, and ultimately decoupled the hrtimer from the clock system. From the perspective of a standalone high-resolution timer implementation, I hold the view that this PR is free of issues. > > 3. The hrtimer proposal has been under discussion for nearly three months since September 24th. > > > > #17065 > > The code scope of impact have gained recognition from all community members. > > Please allow me to approve and merging of this pull request. We will carry out further optimizations and development based on this hrtimer foundation. > > What a shame. How could you ignore #17556 and merge this. It is unfair. I am out. @Fix-Point You’ve got me wrong. I’m not saying that I’ll drop the review of your submission. Instead, I expect you to perform core optimizations based on this version. I noticed that your submission includes a lot of thoughtful details that are missing from the previous one: seqlock implementation and SMP compliance considerations, to name a few. That said, these optimizations won’t block the merging of the prior submission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
