linguini1 commented on PR #17488: URL: https://github.com/apache/nuttx/pull/17488#issuecomment-3679156739
> Boot qemu with ROMFS is enough. This would be the logs to show, since the description "Test passed on qemu" is not descriptive at all. > The description already said: > > > Revert the write API of romfs which contains several bugs. Since no mainline board enable writable feature, the impact is very minor. > > BTW, could you review the patch to understand what's real change happen? Instead asking the contributor to provide the log like this case: > > 1. This feature doesn't output any log > > 2. No any mainline board enable this feature > > 3. This feature is removed from this patch > > > So, what's log do you want @guohao15 provide? Just the logs from booting on QEMU to show that nothing is broken would be good. This is a large change. It's good that no mainline boards enable the feature, but maybe some line of code was accidentally changed/deleted in this revert process. So just some confirmation that ROMFS is otherwise working as normal would be good. When I ask for logs from contributors, I'm not trying to insinuate that their feature/change should produce logs. But the feature must do *something*, so a test case or some proof that they checked a use-case of the feature is good. In this case, just some interaction with ROMFS that shows it is still working regularly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
