acassis commented on code in PR #17788: URL: https://github.com/apache/nuttx/pull/17788#discussion_r2668128533
########## arch/arm/src/kinetis/hardware/kinetis_flexcan.h: ########## @@ -151,9 +151,9 @@ /* Control 1 Register */ -#define CAN_CTRL1_PROSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */ -#define CAN_CTRL1_PROSEG_MASK (7 << CAN_CTRL1_PROSEG_SHIFT) -#define CAN_CTRL1_PROPSEG(x) (((uint32_t)(((uint32_t)(x)) << CAN_CTRL1_PROPSEG_SHIFT)) & CAN_CTRL1_PROSEG_MASK) +#define CAN_CTRL1_PROPSEG_SHIFT (0) /* Bits 0-2: Propagation Segment */ +#define CAN_CTRL1_PROPSEG_MASK (7 << CAN_CTRL1_PROPSEG_SHIFT) Review Comment: @PetervdPerk-NXP seems like this two lines are not aligned (they are 1 space ahead to the right) (0) and (7 << ...) should start at same column of the bottom (third line) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
