Fix-Point commented on PR #17642: URL: https://github.com/apache/nuttx/pull/17642#issuecomment-3721704184
> > > > > > I said yes to this PR, but still said no to : > > > > > > > > > > #17517 > > > > > > > > > > Although it has merged. > > > > > > > > > > It was not until this PR was merged that the quality of the HRTimer met the required standards. > > > > > > > > > > @anchao @wangchdo > > > > > > > > > > The direct merge of part1 PR was made in an unacceptably hasty manner. > > > > > > > > > > > > > > > > > > > > > > > > > > > @GUIDINGLI @Fix-Point > > > > > > > > > The PR received many-approving from PMCs and committers, I don't think there is any problem to merge it firstly. We can working to improve it. It was also improvement for my initial PR three months ago > > > > > > > > > Besides, I am too busy recently to work on this any more, Looking forward to your continue work on queue abstraction for hrtimer. > > > > > > > > > > > > > > > > > > > > > > > > @wangchdo Why was the code merged directly when someone had pointed out bugs in it? It should only be merged after the bugs are fixed – especially given that there were still "Request changes" reviews pending. > > > > > > > > > > > > > > @GUIDINGLI The merged PR is not the one that has"Request changes" reviews pending. Anyway this is not important, the important thing is that I didn't receive any comments from you guys in the PR merged, And I only received you guys' showing off saying that your implementation was better in every aspect than mine in a general way. > > > > > > > > > > > > > > Besides, I did provide over 20 comments in your guys' implementation afterwords pointing out the issues specifically. Without any showing off in a general way. > > > > > > > > > > > > > > Also I added coauthor of Fix-Point in my second PR even though the design is completely different than what you guys want and you guys have been criticizing it and pushing me to revert it with yours constantly. > > > > > > > > > > > > > > Based on this, I think this ting should be end. > > > > > > On December 15th, @xiaoxiang781216 asked me to share my design with you, and I have already pointed out the SMP problems in our WeChat conversation, but you got very angry and accused me of copying your ideas. I find this very strange; why did a technical communication turn out like this? > > Please put yourself in my shoes: if your work were unjustly accused of copying idea, especially when your implementation is clearly more thorough and thoughtful than others, how would you feel? > > I don’t mean to show off in any way—I prefer to speak with data and facts, and I apologize if this upsets you. And I simply want to clarify, after being wrongly accused, that my work is not copied from yours and better. However, you guys just says that it is just an improvement on your implementation. How ridiculous! How can you guys disrespect other contributors like this? > > Now that your code has been merged, although this is not fair to me at all. I respect your effort and will fix the functional correctness issues based on your work. I have already wasted a lot of time, so please don't waste any more of our time, since we both have many other works to do, thank you. > > @Fix-Point This is really my last response to you: > > Did you share your design with me during the short offline discussion in WeChat? I remembered you just kept saying that I did not consider SMP, I then provided a solution to fix it but you said you have better idea, and you will submit a PR to replace mine, this was why I got unhappy saying you stole my idea and quit this talking with you off-line instantly. > > After everything is on-line, I reviewed your implementation carefully, found many in-proper places and pointed them out specifically as comments in your PR. > > You did not upset me with your implementation or your data even your very rude manner, I just want to let proper design being merged. > > I added you as coauthor in my PR to acknowledge your effort of providing tests to verify my implementation, so I think we really should stop talking about this any further Okay, so do you agree to publish our WeChat chat history? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
