xiaoxiang781216 commented on code in PR #17573:
URL: https://github.com/apache/nuttx/pull/17573#discussion_r2670657268
##########
include/nuttx/arch.h:
##########
@@ -2031,7 +2031,8 @@ int up_alarm_tick_cancel(FAR clock_t *ticks);
*
****************************************************************************/
-#if defined(CONFIG_SCHED_TICKLESS) && defined(CONFIG_SCHED_TICKLESS_ALARM)
+#if defined(CONFIG_HRTIMER)|| \
Review Comment:
```suggestion
#if defined(CONFIG_HRTIMER) || \
```
##########
drivers/timers/arch_alarm.c:
##########
@@ -118,8 +118,9 @@ static void ndelay_accurate(unsigned long nanoseconds)
static void oneshot_callback(FAR struct oneshot_lowerhalf_s *lower,
FAR void *arg)
{
-#ifdef CONFIG_SCHED_TICKLESS
- nxsched_timer_expiration();
+#if defined(CONFIG_HRTIMER) || defined(CONFIG_SCHED_TICKLESS)
+ nxsched_process_timer();
Review Comment:
should we update all driver and remove nxsched_timer_expiration
##########
include/nuttx/arch.h:
##########
Review Comment:
should we merge nxsched_timer_expiration and nxsched_process_timer into one
first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
