xiaoxiang781216 commented on code in PR #17644: URL: https://github.com/apache/nuttx/pull/17644#discussion_r2683518022
########## include/nuttx/sched.h: ########## @@ -660,10 +662,13 @@ struct tcb_s /* POSIX Signal Control Fields ********************************************/ - sigset_t sigprocmask; /* Signals that are blocked */ - sigset_t sigwaitmask; /* Waiting for pending signals */ +#ifdef CONFIG_ENABLE_ALL_SIGNALS + sig_deliver_t sigdeliver; Review Comment: move after line 519 ########## syscall/syscall.csv: ########## @@ -103,12 +103,12 @@ "open","fcntl.h","","int","FAR const char *","int","...","mode_t" "pgalloc", "nuttx/arch.h", "defined(CONFIG_BUILD_KERNEL)", "uintptr_t", "uintptr_t", "unsigned int" "pipe2","unistd.h","defined(CONFIG_PIPES) && CONFIG_DEV_PIPE_SIZE > 0","int","int [2]|FAR int *","int" -"poll","poll.h","","int","FAR struct pollfd *","nfds_t","int" +"poll","poll.h","!defined(CONFIG_DISABLE_ALL_SIGNALS)","int","FAR struct pollfd *","nfds_t","int" Review Comment: revert ########## sched/signal/signal.h: ########## @@ -120,7 +120,9 @@ typedef struct sigq_s sigq_t; * structures buffers structures. */ +#ifndef CONFIG_DISABLE_ALL_SIGNALS Review Comment: `#ifdef CONFIG_ENABLE_ALL_SIGNALS` and move to the first patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
