xiaoxiang781216 commented on code in PR #17826:
URL: https://github.com/apache/nuttx/pull/17826#discussion_r2684612361
##########
arch/arm/src/common/Toolchain.defs:
##########
@@ -405,6 +405,7 @@ endif
ifneq ($(CONFIG_CXX_RTTI),y)
ARCHCXXFLAGS += -fno-rtti
endif
+
Review Comment:
revert
##########
boards/sim/sim/sim/scripts/Make.defs:
##########
@@ -186,9 +186,15 @@ endif
ARCHPICFLAGS = -fpic
+ifeq ($(CONFIG_SIM_TOOLCHAIN_CLANG),y)
Review Comment:
it's better to split the change not directly related to c++23 upgrade to new
pr to boost the review proccess.
##########
libs/libc/misc/lib_cxx_initialize.c:
##########
@@ -71,6 +100,65 @@ void lib_cxx_initialize(void)
{
#if defined(CONFIG_ARCH_SIM) && defined(CONFIG_HOST_MACOS)
macho_call_saved_init_funcs();
+#elif defined(USE_ESP32_XTENSA_INIT_ARRAYS)
Review Comment:
why add esp32 specific code in the common place? it's better to adjust esp32
riscv ld to conform the requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
