linguini1 commented on code in PR #17011:
URL: https://github.com/apache/nuttx/pull/17011#discussion_r2686238049


##########
cmake/nuttx_kconfig.cmake:
##########
@@ -80,7 +80,9 @@ function(nuttx_export_kconfig kconfigfile)
       string(REPLACE "${Name}=" "" Value ${NameAndValue})
 
       # remove extra quotes
-      string(REPLACE "\"" "" Value ${Value})
+      if(Value)

Review Comment:
   Without this change, building with CMake fails when a Kconfig variable has 
an empty default value. This causes the windows version of the sim build to 
fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to