xiaoxiang781216 commented on code in PR #17011:
URL: https://github.com/apache/nuttx/pull/17011#discussion_r2691730614
##########
arch/Kconfig:
##########
@@ -1316,11 +1316,11 @@ comment "Board Settings"
config BOARD_LOOPSPERMSEC
int "Delay loops per millisecond"
- default 5000
Review Comment:
default to 0 and check BOARD_LOOPSPERMSEC doesn't equal zero instead
##########
boards/arm64/imx8/imx8qm-mek/include/board.h:
##########
@@ -33,6 +33,12 @@
* Pre-processor Definitions
****************************************************************************/
+#warning "CONFIG_BOARD_LOOPSPERMSEC is set to 0 to prevent CI build errors." \
Review Comment:
this board use arch_alarm and call up_alarm_set_lowerhalf very early, so
CONFIG_BOARD_LOOPSPERMSEC is never used. why do we generate the warning in
this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
