xiaoxiang781216 commented on code in PR #3333:
URL: https://github.com/apache/nuttx-apps/pull/3333#discussion_r2696570485
##########
examples/ipforward/ipforward.c:
##########
@@ -840,7 +840,10 @@ int main(int argc, FAR char *argv[])
/* Wait for receiver thread to terminate */
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
pthread_kill(fwd.if_receiver, 9);
Review Comment:
need pthread_cancel to make receiver exit? please reference the change in
previous pr.
##########
testing/ostest/Makefile:
##########
@@ -31,20 +31,27 @@ MODULE = $(CONFIG_TESTING_OSTEST)
# NuttX OS Test
-CSRCS = getopt.c libc_memmem.c restart.c sigprocmask.c sighand.c \
+CSRCS = getopt.c libc_memmem.c restart.c \
signest.c sighelper.c
+ifeq ($(CONFIG_ENABLE_ALL_SIGNALS),y)
+CSRCS += sighand.c signest.c
+endif
+
MAINSRC = ostest_main.c
ifeq ($(CONFIG_DEV_NULL),y)
CSRCS += dev_null.c
endif
+ifneq ($(CONFIG_DISABLE_ALL_SIGNALS),y)
+CSRCS += sigprocmask.c
ifeq ($(CONFIG_SIG_SIGSTOP_ACTION),y)
ifeq ($(CONFIG_SIG_SIGKILL_ACTION),y)
CSRCS += suspend.c
endif
endif
+endif
Review Comment:
move before line 49
##########
examples/usrsocktest/usrsocktest_wake_with_signal.c:
##########
@@ -560,8 +560,9 @@ static void do_wake_test(enum e_test_type type, int flags)
for (tidx = 0; tidx < nthreads; tidx++)
{
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
pthread_kill(tid[tidx], SIGUSR1);
Review Comment:
ditto
##########
testing/ostest/CMakeLists.txt:
##########
@@ -22,22 +22,22 @@
if(CONFIG_TESTING_OSTEST)
- set(SRCS
- getopt.c
- libc_memmem.c
- restart.c
- sigprocmask.c
- sighand.c
- signest.c
- sighelper.c)
+ set(SRCS getopt.c libc_memmem.c restart.c sighelper.c)
+
+ if(CONFIG_ENABLE_ALL_SIGNALS)
+ list(APPEND SRCS sighand.c signest.c)
+ endif()
if(CONFIG_DEV_NULL)
list(APPEND SRCS dev_null.c)
endif()
- if(CONFIG_SIG_SIGSTOP_ACTION)
- if(CONFIG_SIG_SIGKILL_ACTION)
- list(APPEND SRCS suspend.c)
+ if(NOT CONFIG_DISABLE_ALL_SIGNALS)
+ list(APPEND SRCS sigprocmask.c)
+ if(CONFIG_SIG_SIGSTOP_ACTION)
+ if(CONFIG_SIG_SIGKILL_ACTION)
+ list(APPEND SRCS suspend.c)
+ endif()
endif()
endif()
Review Comment:
move before line 7 and revert the change from lin3 37-40
##########
wireless/ieee802154/i8sak/i8sak_events.c:
##########
@@ -256,7 +256,11 @@ int i8sak_eventlistener_stop(FAR struct i8sak_s *i8sak)
FAR void *value;
i8sak->eventlistener_run = false;
+
+#ifndef CONFIG_DISABLE_ALL_SIGNALS
pthread_kill(i8sak->eventlistener_threadid, 2);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
