anchao commented on code in PR #17958:
URL: https://github.com/apache/nuttx/pull/17958#discussion_r2699806712
##########
sched/irq/irq_attach_wqueue.c:
##########
@@ -128,9 +128,12 @@ static void irq_work_handler(FAR void *arg)
static int irq_default_handler(int irq, FAR void *regs, FAR void *arg)
{
FAR struct irq_work_info_s *info = arg;
- int ret;
+ int ret = IRQ_WAKE_THREAD;
- ret = info->handler(irq, regs, arg);
+ if (info->handler)
Review Comment:
Why would interrupt threading be registered if the handler is null? Isn't
this a waste of CPU resources? I think assertion should be triggered in this
case instead of being ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
