13627105546 commented on code in PR #3316: URL: https://github.com/apache/nuttx-apps/pull/3316#discussion_r2702082480
########## netutils/ping/icmp_ping.c: ########## @@ -53,6 +53,7 @@ ****************************************************************************/ #define ICMP_IOBUFFER_SIZE(x) (sizeof(struct icmp_hdr_s) + (x)) +#define ICMP_SET_FILTER(t) (UINT32_MAX - (1U << (t))) Review Comment: Done. I have updated the macro to use bitwise NOT (~(1U << (t))) as suggested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
