tinnedkarma commented on code in PR #17978:
URL: https://github.com/apache/nuttx/pull/17978#discussion_r2705680261
##########
drivers/clk/clk_divider.c:
##########
@@ -244,10 +244,11 @@ static uint32_t clk_divider_bestdiv(FAR struct clk_s
*clk, uint32_t rate,
}
mindiv = 0;
- if (divider->flags & CLK_DIVIDER_MINDIV_MSK)
+ if ((divider->flags & CLK_DIVIDER_MINDIV_MSK) &&
Review Comment:
Hello @xiaoxiang781216, thank you for your input.
I do not intend to merge it as is. At the moment I'm not sure it's worth
merging at all.
I just opened this PR to "test the waters", see how much attention the nuttx
clk framework will draw, to be honest.
There are some important thing I still need to figure out before I start
splitting into more PRs, hopefully I find some time to document them in the PR
description as well.
I am struggling with the initialization sequence, the clk framework needs
memory allocation, so the clk init is delayed to nx_start, but a lot of things
happens around the stm32 rcc before nx_start. As with my current progress I am
sure I'll find a lot of other things that might be tricky to solve, hence the
reason of opening this PR really early in the development. Maybe there is some
progress done by someone else that might have some useful hints.
That said, I'll track my progress in the PR description. Maybe Issue would
be a better approach, but it hides the code, which I kinda want to be upfront.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
