ppisa commented on code in PR #18039:
URL: https://github.com/apache/nuttx/pull/18039#discussion_r2712433215
##########
drivers/can/ctucanfd_pci.c:
##########
@@ -641,12 +650,24 @@ static int ctucanfd_chrdev_send(FAR struct can_dev_s *dev,
{
fmt.s.ide = 1;
id.s.id_ext = msg->cm_hdr.ch_id;
+
+ /* Set txbuf record used for txconfirm */
+
+# ifdef CONFIG_CAN_TXCONFIRM
+ priv->tx_idbuf[txidx] = CAN_EFF_FLAG | msg->cm_hdr.ch_id;
+# endif
Review Comment:
This looks good, but problem is that test application
https://github.com/apache/nuttx-apps/tree/master/examples/can should be updated
that when `CONFIG_CAN_TXCONFIRM` is enabled and it receives frame with
`hdr.ch_tcf` set it is not counted as the frame received from the other side.
It should be reported probably, but with some test that it is Tx confirmation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
