aviralgarg05 commented on PR #18140: URL: https://github.com/apache/nuttx/pull/18140#issuecomment-3797921763
> > > Please provide some hardware testing information as well. > > > > > > Thank you for the feedback, @linguini1. I don't have access to IMXRT or STM32 physical hardware for direct testing. Below is context and a request for community validation. > > **Technical analysis** > > ``` > > * Root cause: networking stack requires IFF_RUNNING for packet processing (see [[BUG] Ethernet requires now RUNNING status to work #18110](https://github.com/apache/nuttx/issues/18110)). > > > > * Standard pattern: use `netdev_carrier_on/off` to manage the running state. > > > > * Consistency: same calls used in working drivers: > > > > * s32k1xx_enet.c > > * s32k3xx_emac.c > > * kinetis_enet.c > > ``` > > > > > > > > > > > > > > > > > > > > > > > > **What this fix does** > > ``` > > * Adds `netdev_carrier_on(dev)` in `ifup()` to mark link UP. > > > > * Adds `netdev_carrier_off(dev)` in `ifdown()` to mark link DOWN. > > > > * Minimal surgical change matching other drivers. > > ``` > > > > > > > > > > > > > > > > > > > > > > > > **Validation** > > ``` > > * Code follows patterns from working drivers. > > > > * Compiles in CI for affected targets. > > > > * Style checks pass. > > ``` > > > > > > > > > > > > > > > > > > > > > > > > **Request for community testing** I’d appreciate validation on IMXRT/STM32 hardware (basic tests: ping, TCP/UDP). > > If you want, I can update the PR description with this testing note or adjust wording. > > This entire response seems AI generated, but yes, for a change to all of these drivers to be merged, the change must be tested on hardware. You should include that request for testing in your description, and perhaps the person who raised the issue can verify if the change fixes it. Ok I will do that, and yes sorry for using AI to fix my response, wasnt sure how formal that would look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
