xiaoxiang781216 commented on code in PR #18131:
URL: https://github.com/apache/nuttx/pull/18131#discussion_r2726531690
##########
sched/hrtimer/hrtimer_process.c:
##########
@@ -110,15 +110,17 @@ void hrtimer_process(uint64_t now)
/* Leave critical section before invoking the callback */
- spin_unlock_irqrestore(&g_hrtimer_spinlock, flags);
+ write_sequnlock_irqrestore(&g_hrtimer_lock, flags);
/* Invoke the timer callback */
period = func(hrtimer, expired);
/* Re-enter critical section to update timer state */
- flags = spin_lock_irqsave(&g_hrtimer_spinlock);
+ flags = write_seqlock_irqsave(&g_hrtimer_lock);
+
+ hrtimer_mark_running(NULL, cpu);
Review Comment:
hrtimer_unmark_running
##########
sched/hrtimer/hrtimer_cancel.c:
##########
@@ -60,11 +60,12 @@
#ifdef CONFIG_SMP
static inline_function bool hrtimer_is_active(FAR hrtimer_t *hrtimer)
{
+ int cpu;
Review Comment:
move ater line 64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
