xiaoxiang781216 commented on code in PR #18199:
URL: https://github.com/apache/nuttx/pull/18199#discussion_r2749762315
##########
sched/semaphore/sem_clockwait.c:
##########
@@ -137,14 +137,14 @@ int nxsem_clockwait(FAR sem_t *sem, clockid_t clockid,
ret = nxsem_wait(sem);
+ leave_critical_section(flags);
Review Comment:
> Current behavior also causes degradation on SMP: when CPU0 exits the sem
wait, all other CPUs will perform an extra comparison of the timer node. The
correct approach is to delete the current node when CPU0 exits.
Sorry, your statement is wrong for SMP case, since CPU1 hold the critical
section, doesn't block timer interrupt(wdog) happen on CPU0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
