linguini1 commented on code in PR #18266:
URL: https://github.com/apache/nuttx/pull/18266#discussion_r2751581566
##########
include/nuttx/sensors/sensor.h:
##########
@@ -500,23 +500,23 @@ struct sensor_ops_s
FAR struct sensor_device_info_s *info);
/**************************************************************************
- * Name: set_nonwakeup
+ * Name: set_wakeup
*
- * With this method, the user can disable wakeup capacity for the sensor
- * when data or fifo ready to avoid wakeup cpu, and save power.
+ * With this method, the user can enable wakeup capacity for the sensor
+ * when data or fifo ready to wakeup cpu.
*
* Input Parameters:
* lower - The instance of lower half sensor driver.
* filep - The pointer of file, represents each user using sensor.
- * nonwakeup - true(nonwakeup) and false(wakeup)
+ * wakeup - true(wakeup) and false(non-wakeup)
*
* Returned Value:
* Zero (OK) on success; a negated errno value on failure.
*
**************************************************************************/
- CODE int (*set_nonwakeup)(FAR struct sensor_lowerhalf_s *lower,
- FAR struct file *filep, bool nonwakeup);
+ CODE int (*set_wakeup)(FAR struct sensor_lowerhalf_s *lower,
Review Comment:
Could you document this new method here:
https://nuttx.apache.org/docs/latest/components/drivers/special/sensors/sensors_uorb.html
Also, will legacy versions of uORB drivers be affected by not having this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
